Closed ginberg closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.01%. Comparing base (
7a758ab
) to head (6b322cd
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
see #200 The error happens in the Java function 'createSql'; it can't handle if the temporalEndDays is a single value. At first we thought we should add a check in the createTemporalCovariateSettings function (and a couple of related function) so that the user needs to provide a list in case of a single value. But after looking into it, I found that we can solve it in the Java code and so we don't need to make any (possibly breaking) changes.
Also, I have updated the json jar, since we recently updated the version in the pom file. See https://github.com/OHDSI/FeatureExtraction/pull/217