Open alex-odysseus opened 2 months ago
@anthonysena Anthony, I can't assign reviewers, please do so
@alex-odysseus thanks for reviewing this with me on Atlas/WebAPI WG call. Here are some specific tasks from our discussion:
inst/csv/PrespecTemporalAnnualAnalysis.csv
as it is redundant with the analyses already defined in the package.annualPrevalence
parameter to the getDbCovariateData function to expose the ability to compute the annual prevalence. Make sure this is passed to the Java layer so it can properly pass this to the SQL layer...createQuerySql
function of that class, expose an annualPrevalence
parameter to enable passing in the parameter from R and the SkeletonCohortCharacterization layers respectively.
Supporting https://github.com/OHDSI/WebAPI/issues/2331 to enable temporal annual distribution extending the existing temporal functionality
Temporal annual distribution will be effective for Feature Analyses specified in newly added PrespecTemporalAnnualAnalysis.csv
The idea of the functionality is to extract an underlying year for a Covariate of interest so that it can be easily grouped by in Cohort Characterization result visualization in WebAPI / ATLAS
Minor refactoring using Stream and StreamSupport classes
Standard Java formatting applied in a few places (hopefully acceptable)
Referencing SqlRender 1.18.1 in pom.xml
Targeting feature for 3.7.0 (for an unknown reason there is still 3.5.1-SNAPSHOT in 'develop' pom.xml even though 3.6.0 has been officially released