search

OHDSI / Hades

Health Analytics Data-to-Evidence Suite (HADES): A collection of R packages for performing analytics against the Common Data Model.
https://ohdsi.github.io/Hades
Apache License 2.0
22 stars 11 forks source link

Please start versioning all OHDSI packages #7

Closed sdebruyn closed 2 years ago

sdebruyn commented 3 years ago

Most OHDSI packages are not properly versioned. Please start versioning everything with tags or on CRAN to make the lifes of the users a little bit easier. Especially for a package like this one. I would like to pin the version so that my development stack doesn't go haywire when one of the dependencies has an incompatible update.

Everything used to work fine and now I get the following error when I install Hades:

namespace ‘SqlRender’ 1.6.8 is already loaded, but >= 1.7.0 is required
Calls: <Anonymous> ... namespaceImportFrom -> asNamespace -> loadNamespace
Execution halted
ERROR: lazy loading failed for package ‘CohortMethod’
* removing ‘/usr/local/lib/R/site-library/CohortMethod’
Error: Failed to install 'Hades' from GitHub:
  Failed to install 'CohortMethod' from GitHub:
  (converted from warning) installation of package ‘/tmp/RtmppnPysD/file6262b3842/CohortMethod_4.1.0.tar.gz’ had non-zero exit status
ablack3 commented 3 years ago

Hi @sdebruyn, I think Hades packages do have versions both on CRAN and as github tags. For example here are the version tags for Andromeda. Have you tried using the renv package to isolate the specific version of Hades packages you are using? Using this package to install all of Hades is still a bit experimental I think. I just did it without any issues though. Did you try restarting R before installing Hades?

Let us know if you disagree and what improvement you suggest.