OHDSI / Hermes

(DEPRECATED) HERMES is a vocabulary browser tool for OMOP CDM v5
http://www.github.com/ATLAS
Apache License 2.0
6 stars 2 forks source link

Inconsistent Included Concept Count Refresh #46

Open mattlevine22 opened 9 years ago

mattlevine22 commented 9 years ago

With a set of concepts and their descendants selected in the Cart: clicking twice on a Descendants check box causes a refresh of the Included Concept Count, and can sometimes result in a change in the count, despite no net change made to the cart. I have witnessed increases and decreases in the count. I'm not sure of the full scope of the bug, but it is most faithfully reproduced by 1) double clicking on the descendants check box quickly, so that the Included Concepts Count does not refresh between clicks and 2) putting ancestors and some of their descendants explicitly in the cart, while selecting All Descendants for all items in the cart. I think that this double clicking causes a double-counting of the selected items. It is hard to reproduce with only 2 items (parent + 1 child) in the cart, but happens much more easily with 1 parent + many (>8) children. My workaround has been to de-select any Descendants-check box, allow refresh of the count, THEN re-select. My use case for including redundant concepts was just that--to ensure that my cohort with/without that concept had the same overall Included Concept count. Sorry for the long confusing description--I'm happy to clarify and provide a JSON set for import along with a specific instruction set to reproduce.

chrisknoll commented 9 years ago

Sounds like the async refresh of descendant concepts is colliding with the click events coming from the checkbox. One possible solution is to either put some sort of 'patience' timer on clicking on the checkboxes such that we only refresh after a certain amount of inactivity, and also disable the checkbox selection changes while the async is running. Or, add a manual refresh or 'calculate' button but that would be annoying i think.

mattlevine22 commented 9 years ago

I also saw the count oscillate between different numbers (neither of which were correct), so it looks like it should be able to refresh post-click. Does it compute differences between states of the cart to arrive at the number? Or does it start from scratch each time?

El Sep 9, 2015, a las 2:37 PM, Chris Knoll notifications@github.com escribió:

Sounds like the async refresh of descendant concepts is colliding with the click events coming from the checkbox. One possible solution is to either put some sort of 'patience' timer on clicking on the checkboxes such that we only refresh after a certain amount of inactivity, and also disable the checkbox selection changes while the async is running. Or, add a manual refresh or 'calculate' button but that would be annoying i think.

— Reply to this email directly or view it on GitHub https://github.com/OHDSI/Hermes/issues/46#issuecomment-139001142.