Closed writetoritu closed 9 years ago
On the reduction in condition records.
Any thoughts @burrowse?
@mgkahn is against 1:
"I do not think we should be making data up so I do not think we should do 1 for the same reason in your parenthetical."
Agreed @mgkahn @aaron0browne ... I think we want to put the best representation of the data what we have forth and not interpolate any values or make our best guess in this case. The conditions that are not associated with visits are problem list conditions. I think generally speaking a diagnosis from the problem list should be noted on an encounter at least once, so we shouldn't be losing too much condition occurrence data by not being able to map them because of this. I can look into this and provide more specific numbers.
Agreed on the differences in the models, I think that the required fields are indicative of the granularity of information each model is hoping to address when querying for information. Unless PCORnet expands these values are just going to be dropped, but the presence of the condition on the chart remains intact.
Such reasons for discrepancy will be documented in a separate code review document. Closing this issue.
The query seems to be working correctly: When transforming the omop.condition_occurrence table to the pcornet.diagnosis table, we are able to capture all the visits, i.e. the #visits in both tables is the same.
However, there is a discrepancy in #records : #records (omop.condition_occurrence) > #records (pcornet.diagnosis ) because of the following reasons: