OHDSI / OhdsiShinyModules

An R package containing Shiny modules used by various OHDSI Shiny apps
https://ohdsi.github.io/OhdsiShinyModules/
7 stars 9 forks source link

Incidence Rate tab: bugs and suggested enhancements #125

Open pbr6cornell opened 1 year ago

pbr6cornell commented 1 year ago
  1. ENHANCEMENT: Remove all reactive dropdown/checkboxes. Instead, make user pick the desired parameters and then click 'Generate plot'. Currently, with the reactives, each edit to age group, calendar year filter results in refresh, and can queue up and take awhile.

  2. BUG; Download button to the right of the user selections does not work. Not sure if it should produce jpg of graph or tabular output, but currently it generates dowload.html of page that is nonsense.

image

image

  1. POTENTIAL BUG? The hoverover/tooltip show Incidence Proportion as 100% for all cohorts. I would presume this should be % of persons in database that belong to cohort, so definitely isn't 100%. But, it seems like it may be % of persons in cohort who belong to a specific age/sex strata? I don't think thats the desired/expected behavior, but if it is, then should be clearly documented somewhere to avoid confusion. image

  2. ENHANCEMENT: Currently, cohorts are labeled by Cohort field, with a 'lookup' above the graph. It'd be desirable to directly apply the cohort name on the graph (ex. as column heading across trellis.).

gowthamrao commented 1 year ago

i suggest the following default selections for age and sex

image

gowthamrao commented 1 year ago

I would presume this should be % of persons in database that belong to cohort, so definitely isn't 100%.

This has been an issue since beginning, not unique to CD v3. However, @azimov we can remediate this in CD v3 - because we have persons in database in the metadata output (new to version 3).

gowthamrao commented 1 year ago

This code, introduced in version 3 gives us datasource summary that maybe useful here

https://github.com/OHDSI/CohortDiagnostics/blob/befe0eb0e488fa8a4d308fed861cb03c64b67294/R/RunDiagnostics.R#L480-L491

azimov commented 1 year ago

1, 2, and 4 are fixed. 3 Is a more involved issue