OHDSI / OhdsiShinyModules

An R package containing Shiny modules used by various OHDSI Shiny apps
https://ohdsi.github.io/OhdsiShinyModules/
7 stars 11 forks source link

Characterization output seems to take a long time to load - in post processing rendering table #132

Open gowthamrao opened 1 year ago

gowthamrao commented 1 year ago

To reproduce in test environment: select cohort 'Persons with Type 1 Diabetes Mellitus', select atleast 10 data sources, generate table.

Observation: This is a test for a large output - so its expected to take long time. But my observation suggests that the Database extraction step happened relatively fast (seconds), but rendering the output in reactable took long time (8 minutes)

Suggestion: Add a radio button that filters the output from database before sending to reactable - so that reactable only gets output thats above a certain threshold (maybe configured in config.yaml). If the radio button is unselected, then the reactable can display the full result. If radio button is selected - then only the value above the threshold defined in the yaml is shown.

image

azimov commented 1 year ago

Adding a checkbox to censor data does not resolve this issue - Reactable does not support server side renddering. If you select 500Mb of covariates that's what you will get. I strongly advise against pressing "selectAll" on databases - Selectable also has a bug where it doesn't enforce maximum outputs