search

OHDSI / OhdsiShinyModules

An R package containing Shiny modules used by various OHDSI Shiny apps
https://ohdsi.github.io/OhdsiShinyModules/
8 stars 11 forks source link

SCCS module target / indications dropdown shows negative controls #292

Closed schuemie closed 1 month ago

schuemie commented 3 months ago

image

Using 

remotes::install_github('ohdsi/OhdsiShinyModules', ref = 'estimation-updated')
remotes::install_github("ohdsi/ShinyAppBuilder", ref = "estimation")

as requested by @jreps.

This is probably because we’re using negative control exposures in the vignette. Should be an easy fix: add ‘WHERE true_effect_size IS NULL’ here: https://github.com/OHDSI/OhdsiShinyModules/blob/42f5bb42c731fd9ff1a9c96bb68b624fd357ba78/R/helpers-sccsDataPulls.R#L58

Could we also have the drugs listed in alphabetical order?

A nice to have would be if the dropbox after closing shows the selected drug instead of just the indication:

image

I think @azimov has already done some work on this.

jreps commented 3 months ago

This is on a different branch I think?