OHDSI / PatientLevelPrediction

An R package for performing patient level prediction in an observational database in the OMOP Common Data Model.
https://ohdsi.github.io/PatientLevelPrediction
181 stars 88 forks source link

Models save cdmDatabaseSchema as cdmDatabaseName #429

Closed egillax closed 3 months ago

egillax commented 4 months ago

When our models are saving the trainDetails$developmentDatabase they use attr(trainData, "metaData")$cdmDatabaseSchema. (see e.g. cyclopsModels, RClassifier and sklearn )

But in help for createDatabaseDetails it's stated:

cdmDatabaseName
A string with the name of the database - this is used in the shiny app and when externally validating models to name the result list and to specify the folder name when saving validation results (defaults to cdmDatabaseSchema if not specified)

But I believe (but not 100% ) that the models should be using cdmDatabaseName (or cdmDatabaseId) instead. I'm running into this when looking at the external validation and trying to organize output by developmentDatabase but just getting schema names instead of the sharable cdmDatabaseName I specified in the databaseDetails.

egillax commented 3 months ago

fixed in v6.3.7