Closed schuemie closed 5 years ago
Not all function and argument names are in line with the OHDSI code style. For example, estPPV should be estPpv.
estPPV
estPpv
Also, I highly recommend avoiding abbreviations when possible to make code easier to read. For example:
estimatedPpv
createPhenoModel
createPhenotypeModel
exclCohort
xSensCohort
mainPopnCohort
etc.
These have all been corrected in version 1.0
Not all function and argument names are in line with the OHDSI code style. For example,
estPPV
should beestPpv
.Also, I highly recommend avoiding abbreviations when possible to make code easier to read. For example:
estPpv
could beestimatedPpv
createPhenoModel
could becreatePhenotypeModel
exclCohort
could bexSensCohort
mainPopnCohort
could be ? (not sure what this argument does)etc.