OHDSI / PheValuator

An R package for evaluating phenotype algorithms.
https://ohdsi.github.io/PheValuator/
17 stars 6 forks source link

excludedCovariateConceptIds #40

Open abbynewbury opened 6 months ago

abbynewbury commented 6 months ago

Hi, after reading the PheValuator 2.0 paper it seems that no concepts need to be purposefully excluded in a phevaluator analysis now: "It also allows for use of all possible predictors in the models, particularly the health condition diagnosis codes". From this, I am able to set excludedCovariateConceptIds in createDefaultCovariateSettings as null. However, when I look at the definition for this param in the code I see the following description (https://github.com/OHDSI/PheValuator/blob/837a1f2ab4774bf047b28a77dd49a534c7fca451/R/DefaultCovariateSettings.R#L25):

' @param excludedCovariateConceptIds A list of conceptIds to exclude from featureExtraction. These

' should include all concept_ids that were used to define the

' xSpec model (default=NULL)

Was this param description not updated per PheValuator 2.0 or should we still include xSpec concept ids in excludedCovariateConceptIds? Thanks so much!