Defaulting arguments to "" is not helpful

OHDSI / PheValuator

An R package for evaluating phenotype algorithms.

https://ohdsi.github.io/PheValuator/

17 stars 6 forks source link

Defaulting arguments to "" is not helpful #6

Closed schuemie closed 5 years ago

schuemie commented 5 years ago

For example here. If an argument is required, give it a sensible default value if it exists, or else do not give it a default value. (e.g. xSpecCohort,

If it is not required, default it to NULL.

Currently the RStudio code issue highlighter doesn't indicate a problem if a user leave's out a required argument.

jswerdel commented 5 years ago

These were all changed in the PheValuator functions fro version 1.0