Bulk renaming Atlas definitions

OHDSI / ROhdsiWebApi

An R package for interfacing with a WebAPI instance

https://ohdsi.github.io/ROhdsiWebApi

10 stars 17 forks source link

Bulk renaming Atlas definitions #11

Closed gowthamrao closed 4 years ago

gowthamrao commented 5 years ago

A general convention for naming cohorts is with a prefix such as [prefix details]. Prefixes start with '[' and end with ']'. Inside the prefix is some meaningful classification of the project.

It would be nice to have a function that is allows for

searching cohorts that meet a certain string (or regex) inside the prefix
be able to bulk change prefix from '[ABC]' to [DEF]' with some form of confirmation notification/warning.

alondhe commented 5 years ago

So we'd add: getCohortsByPrefix: this would essentially pull back the cohort list and then use grep or something to handle regex searching.

For bulk changing the prefixes, I'm not sure this is a good idea, especially with security not fully enabled. @anthonysena and @chrisknoll -- what are your thoughts?

gowthamrao commented 5 years ago

@chrisknoll @anthonysena @alondhe I think its reasonable to wait till security is fully validated/enabled/implemented.

gowthamrao commented 4 years ago

User may filter returned object from this function https://github.com/OHDSI/ROhdsiWebApi/issues/40

gowthamrao commented 4 years ago

We are now able to get a list of atlas definition details (including names) as R-dataframe. This object may be filtered based on prefix etc. Bulk renaming is still pending To do that we have to solve posting definitions as described here https://github.com/OHDSI/ROhdsiWebApi/issues/42

schuemie commented 4 years ago

I for one am very uncomfortable in programmatically pushing changes to WebAPI. It is too easy to make mistakes, with no easy recovery options.

I would prefer it if ROhdsiWebApi viewed WebAPI as read-only. The way I deal with the prefixes is after I get the information from WebAPI, for example as demonstrated here.

In my opinion, the prefixes are an workaround made necessary because ATLAS doesn't use the notion of projects. Ideally, all this will go away in ATLAS v3.0.

gowthamrao commented 4 years ago

Bulk renaming is still pending To do that we have to solve posting definitions as described here

We have solved posting definitions. But we wont be solving 'bulk renaming' based on @schuemie comment above.