search

OHDSI / ROhdsiWebApi

An R package for interfacing with a WebAPI instance
https://ohdsi.github.io/ROhdsiWebApi
10 stars 17 forks source link

Added fnction to check if a string name exits for a category #119

Closed gowthamrao closed 4 years ago

schuemie commented 4 years ago

For functions that return a boolean, we typically use names like isValid or existsConceptSetName. I recommend we do the same here.

schuemie commented 4 years ago

The build fails as you can see here.

I think this is because you have a $ instead of a %, where indicated

codecov-commenter commented 4 years ago

Codecov Report

Merging #119 into develop will decrease coverage by 30.99%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #119       +/-   ##
===========================================
- Coverage    30.99%   0.00%   -31.00%     
===========================================
  Files           10      10               
  Lines         1110    1145       +35     
===========================================
- Hits           344       0      -344     
- Misses         766    1145      +379
Impacted Files Coverage Δ
R/AutoGeneratedDefinitions.R 0.00% <0.00%> (-21.31%) :arrow_down:
R/Concept.R 0.00% <0.00%> (-100.00%) :arrow_down:
R/WebApi.R 0.00% <0.00%> (-77.62%) :arrow_down:
R/ConceptSet.R 0.00% <0.00%> (-71.43%) :arrow_down:
R/CohortDefinition.R 0.00% <0.00%> (-25.17%) :arrow_down:
R/Private.R 0.00% <0.00%> (-10.72%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 287cb55...1687218. Read the comment docs.