search

OHDSI / ROhdsiWebApi

An R package for interfacing with a WebAPI instance
https://ohdsi.github.io/ROhdsiWebApi
10 stars 17 forks source link

Modify definition #146

Open gowthamrao opened 4 years ago

gowthamrao commented 4 years ago

Currently we can get and post definitions, but we cannot modify definitions. We would like ability to modify definitions e.g. change name, change an parameter etc.. This maybe achieved by replacing an old definition with a new one.

azimov commented 3 years ago

This must be supported by Atlas/WebApi when the id is taken as a parameter.

It looks like this is just different verbage in the HTTP request the Atlas workflow appears to be:

1) User presses save 2) Checks that the name is valid (i.e. is not the name of another cohort) cohortdefinition/<id>/exists?name=Name 3) Calls PUT against the endpoint (not post) with the cohort Id specified

The way this client should work is to take the definition and if id is a parameter; check to see if the cohort exists and then attempts to overwrite it.

The error handling of this process needs to take into account the response of the server.

azimov commented 3 years ago

Modifying cohort and concept set definitions is now supported. Other definitions requires further testing