search

OHDSI / ROhdsiWebApi

An R package for interfacing with a WebAPI instance
https://ohdsi.github.io/ROhdsiWebApi
10 stars 17 forks source link

Fixes #226. #238

Closed chrisknoll closed 2 years ago

chrisknoll commented 2 years ago

Due to how the other getDef functions were being templated, I wasn't able to have the existing getConceptSetDefinition accept a vocab source key as a param. Instead, I had to introduce a new function name to handle that usecase.

codecov[bot] commented 2 years ago

Codecov Report

Merging #238 (bb0f394) into develop (ceed3ac) will decrease coverage by 0.05%. The diff coverage is 77.77%.

:exclamation: Current head bb0f394 differs from pull request most recent head 394f3bc. Consider uploading reports for the commit 394f3bc to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #238      +/-   ##
===========================================
- Coverage    82.64%   82.58%   -0.06%     
===========================================
  Files           17       18       +1     
  Lines         1469     1487      +18     
===========================================
+ Hits          1214     1228      +14     
- Misses         255      259       +4
Impacted Files Coverage Δ
R/getConceptSetDefinitionBySourceKey.R 77.77% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ceed3ac...394f3bc. Read the comment docs.