search

OHDSI / ROhdsiWebApi

An R package for interfacing with a WebAPI instance
https://ohdsi.github.io/ROhdsiWebApi
10 stars 17 forks source link

Add getUsersFromRole function #247

Closed alondhe closed 2 years ago

alondhe commented 2 years ago

246 enhancement - function to get users from a WebAPI role, for security enabled Atlas instances

gowthamrao commented 2 years ago

Hi @alondhe i like the PR, but i am finding it hard to do a review. Mainly because it seems to be bundled with formatting and many changes. There are changes in extras folder. Plus - there are potential merge conflicts etc.

Apologies - but would you be willing to do a clean PR which just the targeted changes?

codecov[bot] commented 2 years ago

Codecov Report

Merging #247 (f48f8f5) into develop (5ae3883) will not change coverage. The diff coverage is n/a.

:exclamation: Current head f48f8f5 differs from pull request most recent head 8560113. Consider uploading reports for the commit 8560113 to get more accurate results

@@           Coverage Diff            @@
##           develop     #247   +/-   ##
========================================
  Coverage    61.93%   61.93%           
========================================
  Files           18       18           
  Lines         1487     1487           
========================================
  Hits           921      921           
  Misses         566      566

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ae3883...8560113. Read the comment docs.