Adds ability to delete atlas ids using ROhdsiWebApi

OHDSI / ROhdsiWebApi

An R package for interfacing with a WebAPI instance

https://ohdsi.github.io/ROhdsiWebApi

10 stars 17 forks source link

Adds ability to delete atlas ids using ROhdsiWebApi #39

Closed gowthamrao closed 4 years ago

gowthamrao commented 4 years ago

Addresses https://github.com/OHDSI/ROhdsiWebApi/issues/38

schuemie commented 4 years ago

Was the inclusion of getCharacterizationDefinitionExpression in this pull request intentional? It doesn't fit the issue description.

Also, the getCharacterizationDefinitionExpression function doesn't follow the proposed design pattern. We can decide to abandon that, but we'd need to have that discussion first.

gowthamrao commented 4 years ago

Hi @schuemie - yes, i should have explicitly stated inclusion of getCharacterizationDefinitionExpression

However, i think the output still follows the proposed convention. See return below. The reason is that `httr::content(json)' parses the object? But it is implicit - let me change the PR to make it explicit