search

OHDSI / ROhdsiWebApi

An R package for interfacing with a WebAPI instance
https://ohdsi.github.io/ROhdsiWebApi
10 stars 17 forks source link

Adds function to post atlas definitions #54

Closed gowthamrao closed 4 years ago

gowthamrao commented 4 years ago

Currently only supports cohort expression. TO DO: conceptSet, cohort characterization etc.

tested Thank you @anthonysena for the code

Addresses https://github.com/OHDSI/ROhdsiWebApi/issues/42

schuemie commented 4 years ago

I would think that if we stick to the pattern discussed earlier, the input to this function would be an R object, not a JSON string. The example code you provide already reads a bit awkward, in that need to translate to JSON ourselves from one ROhdsiWebApi function to the other. I recommend the new function translates to JSON internally.

schuemie commented 4 years ago

I think we can close this pull request, right?

gowthamrao commented 4 years ago

Closing this PR in favor of https://github.com/OHDSI/ROhdsiWebApi/pull/72