search

OHDSI / ROhdsiWebApi

An R package for interfacing with a WebAPI instance
https://ohdsi.github.io/ROhdsiWebApi
10 stars 17 forks source link

Use explicit function names to describe what it is doing #92

Closed gowthamrao closed 4 years ago

gowthamrao commented 4 years ago

Example: we currently have functions called getCohort that are returning cohort definitions. We need to explicitly call them getCohortDefinition.

All names should follow this convention https://github.com/OHDSI/ROhdsiWebApi/issues/86

Similar pattern will need to be implemented for conceptSet, incidenceRate, pathway etc.

gowthamrao commented 4 years ago

Addressed through https://github.com/OHDSI/ROhdsiWebApi/pull/95