search

OHDSI / ResultModelManager

RMM is an R package designed to handle common ohdsi results data management functions by providing a common API for data model migrations and definitions
https://ohdsi.github.io/ResultModelManager/
Apache License 2.0
3 stars 3 forks source link

Do we really need createResultsDataModel()? #22

Closed schuemie closed 1 year ago

schuemie commented 1 year ago

The createResultsDataModel() is just a wrapper around DatabaseConnector::executeSql() that first checks if the schema exists using Postgres-specific code so it can throw an R-generated error. If the user were to use DatabaseConnector::executeSql() instead, the server would actually already throw an error saying the schema doesn't exist, so I don't understand what this function adds.

The most reliable part is one that doesn't exist, so I suggest removing this function.

azimov commented 1 year ago

This code made it in from the OHDSI sharing branch it came from by mistake, it has been removed in develop and will be taken out in the next release.