search

OHDSI / SelfControlledCaseSeries

An R package for performing Self-Controlled Case Series (SCCS) analyses in an observational database in the OMOP Common Data Model.
http://ohdsi.github.io/SelfControlledCaseSeries
13 stars 8 forks source link

summarizeSccsAnalyses - blank sccsEraDataFolder entries #11

Closed alondhe closed 6 years ago

alondhe commented 7 years ago

Hi @schuemie ,

I'm pretty new to the SCCS package, but I noticed that when trying to invoke summarizeSccsAnalyses, it runs into an error because the outcomeModelReference's sccsEraDataFolder array contains blank entries and it thus cannot run loadSccsEraData to load data from a blank location.

First off, should these blank entries exist?

I did make a fork and add a 'quick and dirty' check for the sccsEraDataFolder being blank in the for loop: https://github.com/alondhe/SelfControlledCaseSeries/commit/293e2758d2a1ed39d1829a0503532e70e195a228#diff-335db7e884e649ff936f1cd1728fc9ad

This allowed the function to ignore the blanks and process the summary.

Thanks, Ajit

schuemie commented 7 years ago

Hi @alondhe,

Nope, those entries should not be empty. Could you mail me your analysis code so I reproduce the problem?

alondhe commented 6 years ago

Forgot to close this earlier -- I had a bug in my code :)