search

OHDSI / SelfControlledCaseSeries

An R package for performing Self-Controlled Case Series (SCCS) analyses in an observational database in the OMOP Common Data Model.
http://ohdsi.github.io/SelfControlledCaseSeries
13 stars 8 forks source link

Vignette could use an update #16

Closed OskarGauffin closed 4 years ago

OskarGauffin commented 5 years ago

Great to have the SCCS-framework available in OHDSI. I just want to point out that there are some minor changes in the current version of the SqlRender-package, which I believe are not taken into account in the present version of the vignette (for single studies).

For instance, running

sql <- translateSql(sql, targetDialect = connectionDetails$dbms)$sql

gives you

"Warning message: 'translateSql' is deprecated. Use 'translate' instead."

And if an update of the vignette is made, there is also a comma-sign missing on page three, see "HERE" in code below:

"sql <- renderSql(sql, cdmDatabaseSchema = cdmDatabaseSchema, cohortDatabaseSchema = cohortDatabaseSchema HERE outcomeTable = "my_outcomes")$sql sql <- translateSql(sql, targetDialect = connectionDet"