Updates from Strategus testing

OHDSI / SelfControlledCaseSeries

An R package for performing Self-Controlled Case Series (SCCS) analyses in an observational database in the OMOP Common Data Model.

http://ohdsi.github.io/SelfControlledCaseSeries

13 stars 8 forks source link

Updates from Strategus testing #38

Closed anthonysena closed 1 year ago

anthonysena commented 1 year ago

This is a set of changes I made while testing the SCCS Strategus module. I'm leaving it as a draft for now since there may be other changes based on testing.

schuemie commented 1 year ago

@anthonysena: Looks good, but I can't merge until you declare the PR to be 'final'.

I did notice I changed the class name of connectionDetails to ConnectionDetails in the latest develop version of DatabaseConnector. I'll modify the code so it will work with both.

anthonysena commented 1 year ago

Thanks @schuemie I've marked this PR final.