search

OHDSI / SelfControlledCaseSeries

An R package for performing Self-Controlled Case Series (SCCS) analyses in an observational database in the OMOP Common Data Model.
http://ohdsi.github.io/SelfControlledCaseSeries
13 stars 8 forks source link

Error in SQL "#case_in_period" should be "#cases_in_periods" #53

Closed azimov closed 3 months ago

azimov commented 5 months ago

See attached error. errorReport 3.R.txt

Looking through the source code there are references to a table "#cases_in_periods" plural not "#cases_in_period" singular like in this error message on this line:

https://github.com/OHDSI/SelfControlledCaseSeries/blob/a4a281a8c124a1b2af1f7261641d226ed73f7b70/inst/sql/CreateCases.sql#L110

SelfControlledCaseSeries/inst/sql/CreateCases.sql at a4a281a8c124a1b2af1f7261641d226ed73f7b70 · OHDSI/SelfControlledCaseSeries An R package for performing Self-Controlled Case Series (SCCS) analyses in an observational database in the OMOP Common Data Model. - OHDSI/SelfControlledCaseSeries [11:40] Gilbert, James [JANUS] The reference above is here:

https://github.com/OHDSI/SelfControlledCaseSeries/blob/a4a281a8c124a1b2af1f7261641d226ed73f7b70/inst/sql/CreateCases.sql#L79 SelfControlledCaseSeries/inst/sql/CreateCases.sql at a4a281a8c124a1b2af1f7261641d226ed73f7b70 · OHDSI/SelfControlledCaseSeries An R package for performing Self-Controlled Case Series (SCCS) analyses in an observational database in the OMOP Common Data Model. - OHDSI/SelfControlledCaseSeries

Not sure on steps to reproduce it but I have a PR incoming

azimov commented 5 months ago

To confirm the reproducibility of this bug - call getDbSccsData with a study start date and end date as well as nesting the cohort inside an indication cohort. The fix should allow this process to continue