OHDSI / ShinyDeploy

Shiny apps in this repository will be automatically deployed to the OHDSI Shiny server.
27 stars 38 forks source link

Cannot create pull request #155

Open rekkasa opened 2 years ago

rekkasa commented 2 years ago

I am trying to update the AceBeta9Outcomes app but I get a "This comparison is taking too long to generate" message from github. Is there a proper way of pushing changes to ShinyDeploy?

leeevans commented 2 years ago

It would be helpful to understand if this GitHub diff render problem is caused somehow by the current size of the GitHub ShinyDeploy repo code, or if it is specific to the changes in your PR.

Could you try to create a new PR with a single small commit (maybe just a change to a README.md file) in the AceBeta90Outcomes directory, to see if you get the same error from GitHub? If, so it would indicate the problem is not specific to your PR and I will need to investigate possible solutions/alternatives.

If the new small PR works then it would indicate the issue is with your specific PR and perhaps the info below would be helpful: https://stackoverflow.com/questions/63492643/this-comparison-is-taking-too-long-to-generate-error-on-github Verify that all the updates you are making in your PR are intended. If they are, you could try to break up your PR into multiple smaller PRs.