search

OHDSI / SkeletonCohortCharacterization

Apache License 2.0
2 stars 3 forks source link

Parameter fixes for temp and result schema #38

Closed chrisknoll closed 2 years ago

chrisknoll commented 2 years ago

Several changes in this PR:

  1. Variable names are used when @JsonGetter is applied, leading to a conflict between the Impl in this repo vs. those implemented in others (ie: WebAPI). This PR standardizes it.
  2. Added tests for stratification
  3. Parameterization was confusing for cohort tables and schemas, so now cohortTable is specified that is fully qualified (ie: should include schema in the table param). The previous version was a little confused as to where results schema and temp schema was used.