Fix data types in NegativeControlOutcomes.sql

OHDSI / SkeletonComparativeEffectStudy

An R package that can be used as the starting point to implement a comparative effectiveness study.

4 stars 16 forks source link

Fix data types in NegativeControlOutcomes.sql #19

Closed pavgra closed 4 years ago

pavgra commented 5 years ago

Update https://github.com/OHDSI/SkeletonComparativeEffectStudy/blob/master/inst/sql/sql_server/NegativeControlOutcomes.sql to reflect fixes from https://github.com/OHDSI/circe-be/pull/89 (issue - https://github.com/OHDSI/circe-be/issues/88).

But, in general, I have a question: why do we even need this file in the repo if it is always overwritten during hydration (by the file generated by circe from JSON)? That only causes confusion in my opinion and requires such kind of synchronization

schuemie commented 4 years ago

The original use case for the skeleton was that people would manually modify it for their particular study. The fact that this can now also be done automatically by Hydra is a relatively new development, and doesn't automatically invalidate the original use case.