OHDSI / Themis

Repository for OMOP CDM conventions as defined by THEMIS. These can be reference lists of concepts, pieces of standardized code for data generation or quality certification, and debates.
Apache License 2.0
25 stars 8 forks source link

106: Resolving observation_period_end_date without exact information on a last day PR #187

Closed adambouras closed 1 month ago

adambouras commented 2 months ago
katy-sadowski commented 1 month ago

Thanks @adambouras - it's still not quite right. For observation_period, we will want a sidebar entry just like this one: https://github.com/OHDSI/Themis/blob/846c1004926646227fd28ef1def236ee1cd70929/docs/_data/sidebars/mydoc_sidebar.yml#L57-L59

Then, a page called observation_period.md will need to be added to the pages/observation_period folder that looks just like this one (but links out to the new Themis convention page you created instead): https://github.com/OHDSI/Themis/blob/master/docs/pages/care_site/care_site.md

adambouras commented 1 month ago

Hi @katy-sadowski ,

I have made the changes as requested, thank you for your patience your reviewing the PR

adambouras commented 1 month ago

@katy-sadowski , Hi Katy, I just pushed my changes, could you check thank you