search

OHDSI / Vocabulary-v5.0

Build process for the OHDSI Standardized Vocabularies. Currently not available as independent release.
The Unlicense
214 stars 75 forks source link

relationship_id = 'SPL - RxNorm' wrongly defines hierarchy #908

Open dimshitc opened 10 months ago

dimshitc commented 10 months ago

relationship_id = 'SPL - RxNorm' should not be hierarchical. Or maybe it should be aimed in the other direction, for example here, https://athena.ohdsi.org/search-terms/terms/44340954, the SPL concept subsumes all it's components, while it should be a descendant of the components instead.

or look here: https://epi.jnj.com/atlas/#/concept/1376131

Alexdavv commented 10 months ago

I think the reason it's done in such a way is that SPL classification concepts imply "OR", not "AND" logic of the components included. With the "OR" logic, they should be on the top of their components.

This example actually fits well with this logic - you never get all the components of the first aid kit, right?