source id should be larger than 0

OHDSI / WebAPI

OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications

Apache License 2.0

130 stars 169 forks source link

source id should be larger than 0 #1505

Closed Geunhae-Lee closed 3 years ago

Geunhae-Lee commented 4 years ago

source_id in source table should NOT be zero. If so Incedence Rate Generation will fail on CDM whose source id were 0.

I've tested on version 2.7.6.

Code should detect invalid setting in source table or DDL should have constraints to have positive value.

anthonysena commented 4 years ago

@Geunhae-Lee - the wiki doesn't explicitly state that you must use a source_id > 0 so I think it would be good for us to add that to https://github.com/OHDSI/WebAPI/wiki/CDM-Configuration. Additionally the query used to initialize the source table should use the sequence in the WebAPI vs hard-coding the ID to use.

anthonysena commented 3 years ago

Wiki updated to reflect this information.