search

OHDSI / WebAPI

OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications
Apache License 2.0
126 stars 166 forks source link

CC Export JSON includes aggregate attributes for Prevalence (CustomCriteriaFeature) #1824

Open chrisknoll opened 3 years ago

chrisknoll commented 3 years ago

Expected behavior

I'm not sure, but when exporting a cohort characterization with CriteriaFeatures, those criteria features shouldn't have any aggregate attributes about them.

Actual behavior

Creating a CC design with a prevalence feature contains a aggregate element. Aggregates shouldn't be explcitly defined in prevalence CriteriaFeatures because it's implicit that we are counting people.

Steps to reproduce behavior

See attached design. Below is a screenshot of the attributes included in the PREVALNCE type:

image

StudySpecification.txt

chrisknoll commented 3 years ago

I think I found my answer: aggregate is a field contained in the StandardAnalysisAPI BaseCriteriaFeature interface. So, that explains the behavior, but I don't think it's correct that all CriteriaFeatures should include a 'aggregate' specification.