search

OHDSI / WebAPI

OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications
Apache License 2.0
128 stars 166 forks source link

Request to replace hyphen(-) with underscore(_) - Property naming conventions #2251

Closed davidhcar closed 1 year ago

davidhcar commented 1 year ago

The azure cloud Appservice is not allowing to configure properties with hyphen(-), could this property be updated to use Dot(.) or underscore(_) instead ? Reference: https://learn.microsoft.com/en-us/answers/questions/767956/why-is-hyphen-not-allowed-in-app-setting-name Note: Potentially it impacts on other properties who uses hyphen in their name as well.


<!-- Logging -->
    <spring.jpa.show-sql>false</spring.jpa.show-sql>
chrisknoll commented 1 year ago

We don't have control over those property names, I believe they come from spring's set of configuration variables.

@wivern or @ssuvorov-fls would you be able to confirm?

RowanErasmus commented 1 year ago

@davidhcar if you set SPRING_JPA_SHOWSQL=true as environment variable it should work. There is some documentation on this here: https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#features.external-config.typesafe-configuration-properties.relaxed-binding

RowanErasmus commented 1 year ago

@davidhcar I'm closing this under the presumption that you managed to solve this particular issue.