search

OHDSI / WebAPI

OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications
Apache License 2.0
126 stars 156 forks source link

OpenID Connect custom parameters #2254

Closed RowanErasmus closed 1 year ago

RowanErasmus commented 1 year ago

Hi!

I would like to be able to pass the 'domain_hint' parameter with oidc authorization for 'a slightly more streamlined user experience' (https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow) with Azure Active Directory.

When using it it would look something like this "security.oid.customParams={\"domain_hint\":\"your.org\"}"

Would be happy to hear what you think :-)

chrisknoll commented 1 year ago

We should add documentation to security configuration to indicate the new OpenID config param customParams that takes a comma delim tuple key1:value1,key2:value2.

For Azure AD, the use case is domain_hint:your_org.

chrisknoll commented 1 year ago

We just received a report on the forums indicating a 'circular placeholder reference 'security.oid.customPrams in property definitions', and I'm wondering if there's some sort of cicular reference introduced in this PR. This was when the app is run in a docker environment (IE: broadsea) and i'm not sure if there's some issue there. I didn't see this error when I reviewed this PR, however, I also didn't run it under broadsea.

@RowanErasmus , any thoughts?

Reference: https://forums.ohdsi.org/t/broadsea-installation-using-bigquery/18542/24

RowanErasmus commented 1 year ago

Hi @chrisknoll this issue appeared during developing this feature once and then disappeared again, I'm going to take a closer look tomorrow. In the meanwhile you may want to revert the merge...

RowanErasmus commented 1 year ago

I'm guessing it has to do with caching going belly up in the docker build as this error should not occur because the value is defined in the pom.xml. I've responded in the forum