search

OHDSI / WebAPI

OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications
Apache License 2.0
128 stars 166 forks source link

Enable PC and DPC for source and non-standard concepts #2258

Closed TomWhite-MedStar closed 1 year ago

TomWhite-MedStar commented 1 year ago

This, in combination with a pull request # 721 for Achilles, It solves the issue discussed in this forum post. I confirmed that this works on my Databricks instance.

TomWhite-MedStar commented 1 year ago

@chrisknoll , per discussion, removed Achilles analysis # 40

anthonysena commented 1 year ago

Thanks @TomWhite-MedStar for this contribution! I'd like to wait and see the outcome of OHDSI/Achilles#721. Assuming that is approved and the analyses you've added are included, we'll be able to merge this into WebAPI.

TomWhite-MedStar commented 1 year ago

Thanks. @anthonysena , or @chrisknoll , Do you need any more information from me about OHDSI/Achilles#721?

anthonysena commented 1 year ago

I think we're set on the WebAPI side @TomWhite-MedStar. I just want to make sure that the analysis IDs referenced in the WebAPI query are the ones that are finalized in Achilles. I know that we could merge this in now but in the off-chance that the Achilles folks have any desire to change analysis IDs for some reason, we'd have to patch this up.

chrisknoll commented 1 year ago

I think it'll be a low possibility that they will object to the analysis_ids so how about we accept it here with that slight risk, and if they do change the analysis_ids, we can patch.

anthonysena commented 1 year ago

That's good by me thanks @chrisknoll