search

OHDSI / WebAPI

OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications
Apache License 2.0
130 stars 169 forks source link

Update Dependencies and address defaultGlobalReadOnly param #2305

Closed chrisknoll closed 1 year ago

chrisknoll commented 1 year ago

Updated circe to version 1.11.1 Updated StandardAnalysisUtils to 1.4.0. Fixed the assignment of defaultGlobalReadOnly field.

chrisknoll commented 1 year ago

@rkboyce , just FYI, I found something odd in how the permissions were being specified...although I did the previous PR and tested the functionality, I didn't pay close enough to what the value of the paramter was vs. what it represented (ie, was testing turning it on and off to test the difference but didn't look closely at the name).

In this case, We are talking about the setting security.defaultGlobalReadPermissions, which sounds like if it is true, you would be granted global read permissions by default. But what I found in code was a sort of reversal:

    @Value("#{'${security.defaultGlobalReadPermissions}'.equals(false)}")
    private boolean defaultGlobalReadPermissions;

So it's storing the field 'defaultGlobalReadPermissions as the opposite value that was specified in the config...which feels wrong. I've updated it here:

    @Value("${security.defaultGlobalReadPermissions}")
    private boolean defaultGlobalReadPermissions;

I am pinging you here because you may have this deployed in your own environment where you are reversing the value (true vs. false) in your own config, and I just wanted to let you know of the correction I'm making here.