Open alex-odysseus opened 7 months ago
The date adjustment with additional control for +/- isn't necessary and should be removed from this since it's not about a calculation function (nor should it be the case that in order to add or subtract values should be implemented as a 'calculation function').
Business Requirements
As the OMOP CDM Data Set entries don't necessary contain the events of interest for there further inclusion in analyses there should be a possibility:
Design Ideas and Functional Requirements
Calculations between multiple Measurements use case
There are two alternative Circe model extensions to consider:
To avoid any ambiguity when an event in the calculation is taken into consideration in a formula there should be a possibility to define if the first or the last one should be used when multiple. Belonging to the same Visit option shouldn't be neglected as well when required
The calculations should be allowed between "value as number" attributes in Measurements and the following operators should be supported "+", "-"
The start of a pregnancy use case
The date adjustment attribute is suggested to use with an additional sign control ("-" or "+")![image](https://github.com/OHDSI/WebAPI/assets/75131044/7d77e7fd-d7b6-43e7-a128-d6b25874fa89)
Note: As the edit controls support entering negative numbers introducing the new sign controls are rather redundant
Open Questions
@mrechkem @Sathyaraos @tomwhite (please supplement the issue with any further use cases)