search

OHDSI / WebAPI

OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications
Apache License 2.0
126 stars 156 forks source link

Fix/flyway atlas read only user #2342

Open rkboyce opened 5 months ago

rkboyce commented 5 months ago

This is a fix to the Atlas read-restricted role permissions SQL. The prior SQL permissions select statement did not adequately address multiple schemas for vocabulary and sources. As a result, some the intended read access would not work as expected for some WebAPI configurations. This script does a better job of accounting for all sources and schemas relevant to the user.

chrisknoll commented 3 months ago

With the update for WildCard permissions in #2355, we should be able to just use permissions to grant permission to any source. ie: `vocabulary::concept::get` will let you query concepts from any source vocab. Also, this will work with any existing or future source because new source keys will match with .

@rkboyce: would you try to perform a test on your env with the branch from #2355, and possibly will need to make a new source for testing because if this PR was deployed to your WebAPI DB, then you have all the source-specific permissions granted already and you want to test it on a new source (so the * takes effect).