OHDSI / WebAPI

OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications
Apache License 2.0
126 stars 156 forks source link

Fix generation status query errors when source is deleted. #2361

Closed chrisknoll closed 2 months ago

chrisknoll commented 2 months ago

Added migration to alter views to not return any generations for sources that do not exist. Fixes #2360.

There is a problem of consistency in the codebase about when entity graphs are used when the @transactional annotation is used, and the use of views to track generation info (ie: the source may be deleted but we can't set a foreign key to a spring batch job table based on a string_value column. We should have maintained our entity-specific generation status table instead of trying to generically use the job_execution table to store this. We will revisit this decision in WebAPI 3.0.