search

OHDSI / WebAPI

OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications
Apache License 2.0
130 stars 169 forks source link

Add IRIS support to WebAPI #2409

Open anthonysena opened 1 week ago

anthonysena commented 1 week ago

Based on the work done to support IRIS in SqlRender v1.19, we'd like to add the necessary changes to WebAPI to carry these changes through for Atlas.

One question related to this change: are there any restriction on the number of items in the IN clause? This came up in #2284 and we'd like to confirm this.

@bdeboe @alex-odysseus

bdeboe commented 1 week ago

Hi @anthonysena ,

we have a fork of this repository available at https://github.com/intersystems-community/OHDSI-WebAPI, but need to first get the one for https://github.com/intersystems-community/OHDSI-DatabaseConnector into the regular OHDSI repository. That work is all ready to submit, but requires that we also make a test server available for OHDSI team members to validate the work. Unfortunately, we're hitting a cluster of red tape internally, with the test server requiring an OS for which our current license provider's contract had to be replaced etc etc :-( These contracting issues could / should be addressed any day now, so hopefully this won't take much longer.

The repositories referenced above should allow you to get a working version together. If not, please do reach out and we'd be happy to assist!

Thanks, benjamin

anthonysena commented 1 week ago

Thanks for this update @bdeboe. In speaking with @alex-odysseus they are working on making the changes to WebAPI and these references will be helpful.

I didn't go through the code but did you have to make changes to support any limit in the IN clause as I mentioned earlier in this issue?

bdeboe commented 1 week ago

Not sure whether you're asking @alex-odysseus wrt Snowflake, but as far as InterSystems IRIS is concerned we do have a hard limit around 32k, which should be OK given the getParameterLimit() implementation you referenced in #2284 .

anthonysena commented 1 week ago

Thanks @bdeboe I was asking this of you since @alex-odysseus mentioned they were working on adding the IRIS support and we were unsure of this limit. I think we can treat it the same way we are with Google BigQuery and Snowflake. Thanks!