Remove CohortService - Githubissues

OHDSI / WebAPI

OHDSI WebAPI contains all OHDSI services that can be called from OHDSI applications

Apache License 2.0

130 stars 169 forks source link

Remove CohortService #98

Open fdefalco opened 8 years ago

fdefalco commented 8 years ago

This is an antiquated service call that I believe should be removed.

charhart commented 8 years ago

We still use this internally to transfer cohorts back and forth between different sytems and the CDM

fdefalco commented 8 years ago

How are you using it without specifying a sourceKey?

charhart commented 8 years ago

It existed before that was changed and it was just never converted over. I think It still works. I think @jduke99 is still using it. It may just need to be converted to use source.

I'll have to verify that it still works,, but I know we still expected to be an available end point.

charhart commented 8 years ago

Nothing requires source, so that's why it still works. You can get a list of cohort definitions with a source and a source isn't in the cohort table, so it isn't explicitly required. We only have one CDM, so it hasn't been an issue. I would say, if anything needs to be changed, it's to make this service include source.

anthonysena commented 5 years ago

Since this endpoint was retained in the 2.x version of WebAPI, I'd propose that we determine:

Is this functionality already covered by an existing endpoint in the 2.x stack? If so, we should mark this method as deprecated with the intention of removing it in the v3.0.0
If this endpoint has functionality that is not covered elsewhere in the API, determine that gap and decide how to address it for v3.0.0.

For the 2.8 release, let's make this determination and close this out.

anthonysena commented 4 years ago

Let's remove it when we move to 3.0.