Check cohorts before instanitation

[gowthamrao]

This is a wish

• sometime we may have accidentally created a cohort where we forgot to select the conceptId e.g.

Ofcourse this was a human error, but we can miss them. Atlas UI does a nice job of warning, but we may still miss them.

It would , if instantiated, lead to very large cohort - essentially a copy of the condition_occurrence table.

It would be nice - if cohortGenerator does a check of the cohortDefinitionSet object for such potentially silly mistakes e.g. validateCohortsInCohortDefinitionSet ?

[anthonysena]

@gowthamrao - I transferred this from CohortGenerator to circe-be since this type of validation check exists in circe-be (although it may be limited). The functionality in circe-be is what powers the 'Messages' tab in the cohort definition editor in Atlas.

This functionality could be exposed via CirceR if we wanted to also have this available in R and could be done as part of validating the definition prior to generating.

[chrisknoll]

Ok, so how I would deal with this is that we need a function in Circe-be to expose getting warnings....and on the CohortGenerator side, we would call the function to check for critical problems.

So maybe we route this back to CohortGenerator, but open up a circe-be (or circeR) request to expose a function to get warnings.