Open vvcb opened 2 months ago
@lawrenceadams , thank you for reviewing this. Agree with most things - but this was to get the devcontainer working with the existing codebase in preparation for the OHDSI symposium software demo to allow users to spin this up in their own GitHub codespaces.
Disagree with a few. Very happy for any of this to be modified as long as it works for everyone.
In all honesty is good to go for all intents and purposes, a lot of these issues are a reflection of python being annoying to manage packages with IMHO!
@vvcb thanks for working on this - i left a couple comments. also needs a rebase to incorporate recent changes 😄
i had been waiting for Heidi to take a look since Codespaces was her idea ... will ping in Teams to make sure she saw this.
As discussed at the dbt sync community call on 2024-09-20, this PR adds devcontainer support to the project.
Key features:
./dbt-env/bin/python3
to allow the extension to work - this requires a longer-term fix where the extension recognises this automatically.The user will have to run
dbt run
to create the rest of the models.