search

OHDSI / dbt-synthea

[Under development] A dbt ETL project to convert a Synthea synthetic data set into the OMOP CDM
https://ohdsi.github.io/dbt-synthea/
Apache License 2.0
16 stars 6 forks source link

Inconsistent keyword quoting in staging models #76

Closed lawrenceadams closed 1 month ago

lawrenceadams commented 1 month ago

Within the synthea staging models - some keywords (or things that one would think are SQL keywords) are quoted inconsistently.

For example:

https://github.com/OHDSI/dbt-synthea/blob/ae791145d50c9e0693880ff9ed37d60f7cc0195d/models/staging/synthea/stg_synthea__imaging_studies.sql#L16

vs (how all the other models do it)

https://github.com/OHDSI/dbt-synthea/blob/ae791145d50c9e0693880ff9ed37d60f7cc0195d/models/staging/synthea/stg_synthea__encounters.sql#L16

This doesn't effect just id but others such as description, name. Neither of these are keywords for the databases we support as of time of writing (duckdb, postgres)

lawrenceadams commented 1 month ago

This and this may be of help