OHDSI / dbt-synthea

[Under development] A dbt ETL project to convert a Synthea synthetic data set into the OMOP CDM
https://ohdsi.github.io/dbt-synthea/
Apache License 2.0
16 stars 6 forks source link

Fix inconsistent keyword quoting in staging models #78

Closed lawrenceadams closed 1 month ago

lawrenceadams commented 1 month ago

This PR harmonises the variation in quoting of keywords in the staging models. Before this PR keyword quoting was not consistent between models. Furthermore, quoted column names were not safely passed through by the lowercase_columns macro.

Why bother?

An alternative approach would be to treat more of these as keywords, but having explored the ANSI standard as well as the postgres/duckdb/snowflake docs none of the ones I have removed seem to be keywords (excluding name which is now treated as a keyword throughout the repo [was only in places before])

lawrenceadams commented 1 month ago

Don't worry I've done the same! 😆