search

OHDSI / dbt-synthea

[Under development] A dbt ETL project to convert a Synthea synthetic data set into the OMOP CDM
https://ohdsi.github.io/dbt-synthea/
Apache License 2.0
16 stars 6 forks source link

chore: Update model `yml` column definitions / metadata #98

Closed lawrenceadams closed 5 days ago

lawrenceadams commented 2 weeks ago

The model metadata outlined in various yml files throughout the project are out of date.

For example it would appear that the medications staging file only has datetime columns: https://github.com/OHDSI/dbt-synthea/blob/1c148f27f223bfbb008720ff5cb41bbfee71e24e/models/staging/synthea/_synthea__models.yml#L559-L565

However, there are more columns which are not referenced:

https://github.com/OHDSI/dbt-synthea/blob/1c148f27f223bfbb008720ff5cb41bbfee71e24e/models/staging/synthea/stg_synthea__medications.sql#L15-L31

This can / will cause problems in the future, and should be updated to properly reflect what we expect in each model.

lawrenceadams commented 2 weeks ago

(Thanks to @katy-sadowski for reminding me via #96 )

katy-sadowski commented 2 weeks ago

Oof, good catch! I forgot to update the schema files when I added that type cleaning a while back. I'll do this one :)