OHDSI / omock

https://ohdsi.github.io/omock/
Apache License 2.0
2 stars 1 forks source link

adding a default name for emptyCdmReference #23

Closed ilovemane closed 6 months ago

ilovemane commented 6 months ago

It seem a bit annoying to type in the name of the mock cdm. Shall we have the default to be emptyCdmReference("mock cdm")? @edward-burn @nmercadeb

edward-burn commented 6 months ago

We're reexporting this from omopgenerics so for this you might have to persuade @catalamarti

catalamarti commented 6 months ago

maybe we can create emptyMock():

emptyMock <- function() {
omopgenerics::emptyCdmReference(cdmName = "mock database")
}

So I see why for omock it is nice to have a default, but this deafult does not make sense for omopgenerics.

@edward-burn @ilovemane @nmercadeb

ilovemane commented 6 months ago

this sound cool to me!

edward-burn commented 6 months ago

mockCdmReference() %>% mockPerson() ?