search

OHHAKO / reatsby

React + Gatsby :smile:
https://ohhako.github.io/react-app/
1 stars 0 forks source link

feat: show boards and articles #12

Closed kkyueing closed 3 years ago

kkyueing commented 4 years ago

The site should show a list of boards, and each board, in turn, should show a list of articles.

The structure would be like the following:

<App>
  <BoardList>
    <Board>
      <ArticleList>
        <ArticleRow />
        <ArticleRow />
        ...
       </ArticleList>
     </Board>
    <Board>
    ...
    </Board>
  </BoardList>
</App>
OHHAKO commented 4 years ago

are those tags were made by you or be assigned from bootstrap/ jxs?

kkyueing commented 4 years ago

I haven't made them yet. The code above is just a proposal. If you think the proposal is okay, I'll create a PR implementing those components.

kkyueing commented 4 years ago

I've just learnt that it is conventional to send an incomplete PR to encourage discussions between developers. So I've sent the PR #15 which contains a code implements the idea suggested in this issue.

Please just take a look at it and let me know your thought. 😄