OHI-Science / kor

OHI+ assessment for the Republic of Korea (South Korea)
1 stars 1 forks source link

Questions for regions #3

Closed MijuKim closed 6 years ago

MijuKim commented 6 years ago

There are 12 regions in "regions_list.csv" and 11 regions in "rgn_offshore_data.csv." The latter is the one we provided to you. But I don't understand why two are different. The former has "Seoul", which is not a coastal city. And the areas are quite different from each other.

I've looked at a few files such as "fis_meancatch_gl2016.csv" and the region id is 1 to 12. But we are going to assess by 11 regions not by 12. So I'm confused. I'd be very grateful if anybody can clarify or explain this.

Thanks!

jules32 commented 6 years ago

Hi Miju,

Thanks for noticing this error; I think I know how I did that and I'll fix it as soon as I can. I'm out of the office tomorrow but I'll let you know when it's done. You can continue exploring in the meantime since the Toolbox works with any number of regions.

Julie

On Thu, Sep 28, 2017 at 4:58 PM, MijuKim notifications@github.com wrote:

There are 12 regions in "regions_list.csv" and 11 regions in "rgn_offshore_data.csv." The latter is the one we provided to you. But I don't understand why two are different. The former has "Seoul", which is not a coastal city. And the areas are quite different from each other.

I've looked at a few files such as "fis_meancatch_gl2016.csv" and the region id is 1 to 12. But we are going to assess by 11 regions not by 12. So I'm confused. I'd be very grateful if anybody can clarify or explain this.

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OHI-Science/kor/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AFnnRbHosrrW8J0e8pVw19Xiogflna54ks5snDKugaJpZM4PoCZn .

--

Julia Stewart Lowndes, PhD Ocean Health Index National Center for Ecological Analysis and Synthesis (NCEAS) University of California, Santa Barbara (UCSB) website http://jules32.github.io/ • ohi-science http://ohi-science.org/ • github https://github.com/jules32 • twitter https://twitter.com/juliesquid

MijuKim commented 6 years ago

Hi Julie,

Thanks for quick reply. Have a nice weekend!

Miju

jules32 commented 6 years ago

Hi @MijuKim,

I've recreated the repository with the correction; you have the 11 regions listed in regions_list.csv and the layers .csv files in the /layers folder all have 11 regions as well.

I apologize again for the mistake! Please let me know when you have more questions (or see any other errors, although it should all be OK now).

Best, Julie

MijuKim commented 6 years ago

Hi @jules32 ,

Thank you very much! I'm so excited to see the files.

Best, Miju