search

OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.38k stars 3.41k forks source link

Enable FullScreen mode for #1791

Open letsimplement opened 4 years ago

letsimplement commented 4 years ago

:hand: Many people requests features. Tell us why yours is important to the community. How does it add value? Why this feature?

Is your request very specific to your needs? Consider contributing it yourself! Or reach out to a community member that offers consulting services.

Request

What feature or change would you like to see made? We would like to be able to perform the following action in the toolbar.

  1. Possibility to switch to a full-screen view and switch back
  2. Possibility to print an active image ...

Why should we prioritize this feature?

...

sedghi commented 1 year ago

I think we should really

james-hanks commented 1 year ago

@jbocce to provide estimate for basic:

We will revisit further enhancements after this prototype: floating toolbars, swap between full screen viewports, more than 1 viewport full screen

jbocce commented 1 year ago

After some investigation, I believe the effort for a minimal implementation as described by @james-hanks in this comment requires minimal effort including some testing on development's part.

From my investigation, I found that while a viewport is in fullscreen there is already the ability to press Esc to exit full screen. Also OHIF keyboard shortcuts and actions such as double click to 1x1 and switching hanging protocol stages is handled somewhat gracefully without causing errors in the app. For example, switching to a different protocol stage will exit full screen should the viewport that was in full screen no longer exist. However we might want to consider at some point putting some restrictions on what is possible in full screen.

jbocce commented 1 year ago

I split out the printing request into feature request #3753.